Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Vector256 tests which are timing out #64653

Merged
merged 2 commits into from
Feb 2, 2022

Conversation

sbomer
Copy link
Member

@sbomer sbomer commented Feb 1, 2022

Disables test which is timing out in ci (rolling builds and PRs): #60154

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@echesakov
Copy link
Contributor

Looks good, I will consolidate the remaining changes from #63357 when you merge this.

src/tests/issues.targets Outdated Show resolved Hide resolved
@sbomer sbomer merged commit 6527b7f into dotnet:main Feb 2, 2022
@AndyAyersMS
Copy link
Member

Now that we skip that test we make it to Vector128_ro which likewise times out:

https://dev.azure.com/dnceng/public/_build/results?buildId=1586485&view=ms.vss-test-web.build-test-results-tab

@tannergooding
Copy link
Member

tannergooding commented Feb 2, 2022

@echesakovMSFT It might be better/easier to just skip these tests on Arm32 exclusively. Or maybe to add a special fast path in the tests (they are autogenerated so this would be easy, just a lot of churn) that effectively does an if platform == arm32 { early exit }

If the issue here is indeed that the combination of process startup + throwing exception is too slow on Arm32 (I imagine x86 Linux is also impacted), the most trivial fix might be to just assume that IsNotSupported is correct since we aren't really updating those platforms at all.

The NotSupported logic then at least gets validated on the x64/Arm64 Outerloop when we test COMPlus_EnableHWIntrinsic=0

@ghost ghost locked as resolved and limited conversation to collaborators Mar 4, 2022
@sbomer sbomer deleted the disableJITTests branch November 3, 2023 18:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants